Skip to content

feat: Tag Result Storage Objects with Original Filename (#275)#362

Open
schwarmco wants to merge 4 commits into
thumbor:mainfrom
schwarmco:feature/275-result-storage-tagging
Open

feat: Tag Result Storage Objects with Original Filename (#275)#362
schwarmco wants to merge 4 commits into
thumbor:mainfrom
schwarmco:feature/275-result-storage-tagging

Conversation

@schwarmco

Copy link
Copy Markdown

Closes #275

@schwarmco schwarmco requested a review from a team as a code owner April 15, 2026 18:22
@schwarmco schwarmco requested a review from guilhermef April 15, 2026 18:22
@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 45 days with no activity. Remove the stale label or add a comment, or this PR will be closed in 10 days. You can always re-open if you feel this is something we should still keep working on. Tag @heynemann for more information.

@github-actions github-actions Bot added the Stale label May 30, 2026
@schwarmco

Copy link
Copy Markdown
Author

any feedback on this? @guilhermef @heynemann

@github-actions github-actions Bot removed the Stale label May 31, 2026
@guilhermef

Copy link
Copy Markdown
Member

@schwarmco please add a test for the tag

@schwarmco

Copy link
Copy Markdown
Author

@schwarmco please add a test for the tag

i've added a test to verify that the tag gets set correctly .. i had to to alter the Context Mocks so please let me know if this is a false assumption (but image_url was present in all my tests)

i did not intend to implement any get_tags into thumbor-aws's S3Client, as this seems out of scope?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cache Invalidation of Result Storage Objects

2 participants